Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate DLL's to PROJECTM_BIN_DIR on Windows #764

Conversation

Blaquewithaq
Copy link
Contributor

I have submitted this pull request with the intention of aligning the output directory structure more closely with the conventions observed on Windows.

DLL's are more commonly found in /bin directories.

I'm also working on the VCPKG packaging and this is their preferred structure.

Copy link
Member

@kblaschke kblaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing the same thing twice, better move the code to the main CMakeLists.txt.

Additionally, using if(WIN32) is long deprecated, and will cease to work at some point. Please use if(CMAKE_SYSTEM_NAME STREQUAL Windows) instead.

@Blaquewithaq Blaquewithaq force-pushed the relocate-dlls-on-windows branch from 47dbb2c to d64bf28 Compare February 2, 2024 14:03
Copy link
Member

@kblaschke kblaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean!

@Blaquewithaq Blaquewithaq force-pushed the relocate-dlls-on-windows branch from d64bf28 to 0beb7a2 Compare February 2, 2024 16:23
@Blaquewithaq Blaquewithaq merged commit 0beb7a2 into projectM-visualizer:master Feb 2, 2024
9 checks passed
@Blaquewithaq Blaquewithaq deleted the relocate-dlls-on-windows branch February 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants