Properly cast argument types in GLSL #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblaschke
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Please reconsider the line width changes, as I've specifically kept it this way because of the stated reasons - it will make things worse (e.g. not rendering any lines) on some platforms, which are now working fine.
Plus, debug output should either be done via a proper API (in release 4.2), or wrapped in #ifdefs to only make them available in debug builds.
dpw13
force-pushed
the
dev/dwagner-abs-casting
branch
from
ad27ae8 to
8500248
Compare
kblaschke
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was occasionally getting type errors around the
powfunction after #779. This appears to be because the type casting used inOutputExpressionListwas being omitted. For the other functions with an addedabscall, I useOutputExpressionListto recapture the previous casting behavior and forpowI use the function's return type, ensuring that all arguments are expanded into vectors where possible.powin particular is often used in presets where the base or exponent is a scalar and the other argument is a vector.