[release tool] security fixes #9283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radTuti
added
docs-not-required
radTuti
force-pushed
the
hashrelease-fixes
branch
4 times, most recently
from
6391b2c
to
cc9b41b
Compare
Behnam-Shobiri
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
While we using the SSH for doc website with static IP and hostname, we should be fine.
@radTuti can you please add that in the comments?
"This config (disabling strict verification) is only accepted for doc website with static IP and hostname"
radTuti
force-pushed
the
hashrelease-fixes
branch
from
cc9b41b
to
5791739
Compare
radTuti
force-pushed
the
hashrelease-fixes
branch
from
5791739
to
b6f03d3
Compare
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Sep 28, 2024
* disable security check for ISS server * remove using ssh.InsecureIgnoreHostKey
radTuti
added a commit
that referenced
this pull request
Oct 1, 2024
[cherry pick] [release tool] security fixes (#9283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ssh.InsecureIgnoreHostKeyRelated issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.