add an implement for calicoctl version --client #9291
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
There was a problem hiding this comment.
One minor comment, but otherwise LGTM - thanks for picking this up @cyclinder !
| @@ -56,6 +56,8 @@ Options: | |||
| --poll=<POLL> Poll for changes to the cluster information at a frequency specified using POLL duration | |||
| (e.g. 1s, 10m, 2h etc.). A value of 0 (the default) disables polling. | |||
| --allow-version-mismatch Allow client and cluster versions mismatch. | |||
| --client Display the client version only. | |||
There was a problem hiding this comment.
Indentation looks off here
There was a problem hiding this comment.
Oh, it looks good in my vscode, let me recheck it.
cyclinder
force-pushed
the
calicoctl_client_version
branch
from
53c3f97
to
0828a75
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud>
cyclinder
force-pushed
the
calicoctl_client_version
branch
from
0828a75
to
bffed28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add an implement for calicoctl version --client
Related issues/PRs
fixes #9244
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.