Embed CRD files using Go's embed library, remove old auto-gen #9297
+144
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
fasaxc
added
docs-not-required
Bye bye crds.go. Your long lines won't be missed.
coutinhop
approved these changes
Oct 1, 2024
|
/merge-when-ready squash-commits |
|
OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it. |
|
Removing "merge-when-ready" label due to new commits |
|
/merge-when-ready |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
|
Removing "merge-when-ready" label due to new commits |
|
/merge-when-ready squash-commits |
|
OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Go now has a blessed way to embed files in the built executable. Use that in favour of our home-grown script that embedded the CRDs into strings in calicoctl.
Note: the old logic looked bugged, in that not all CRDs were applied by calicoctl. We now include all the CRDs in the libcalico-go/config/crd directory. Hopefully that is what was intended!
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.