Match correct value for support_suspend #254
Conversation
src/guest/vm_builder_qemu.cc
Outdated
| if (aaf_suspend.compare("true") == 0 || aaf_suspend.compare("false") == 0) { | ||
| aaf_cfg_->Set(kAafKeySuspend, aaf_suspend); | ||
| } else { | ||
| LOG(warning) << "The value of 'support_suspend' in aaf should be true or false!"; |
There was a problem hiding this comment.
LOG(error) << "Invalid value of 'support_suspend'";
src/guest/vm_builder_qemu.cc
Outdated
| @@ -647,7 +647,11 @@ void VmBuilderQemu::BuildAafCfg(void) { | |||
|
|
|||
| std::string aaf_suspend = cfg_.GetValue(kGroupAaf, kAafSuspend); | |||
| if (!aaf_suspend.empty()) { | |||
| aaf_cfg_->Set(kAafKeySuspend, aaf_suspend); | |||
| if (aaf_suspend.compare("true") == 0 || aaf_suspend.compare("false") == 0) { | |||
There was a problem hiding this comment.
I am thinking about compatible with enable/disable.
true/enable ==> aaf_cfg_.Set(kAafKeySuspend, "true");
false/disable ==> aaf_cfg_.Set(kAafKeySuspend, "false");
others ==> report error and refuse to start VM
Tracked-On: OAM-104956 Signed-off-by: blackdobb <xinxin.wan@intel.com>
There was a problem hiding this comment.
Failure when executing preintegration builder
FAILURE:Trigger Builds Triggered: build-celt - r1 (caas), build-celt - r1 (caas_sriov), build-celt - r1 (celadon_ivi), build-celt - r2 (r2_caas), build-celt - r2 (r2_caas_sriov) - extra
More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/4706
There was a problem hiding this comment.
PR integrated into 'preintegration' builder
More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/4711
Done by "Wan, Xinxin" xinxin.wan@intel.com
There was a problem hiding this comment.
PR integrated into 'premerge' builder
More details, logs, and binaries: /absp/builders/celadon-premerge/builds/2714
Done by "Wan, Xinxin" xinxin.wan@intel.com
There was a problem hiding this comment.
cactus finished building and testing your changes
It was requested for merge by "Wan, Xinxin" xinxin.wan@intel.com
so we merge it. Thanks for your contribution.
more details, logs, and binaries: /absp/builders/celadon-mergerequest/builds/3122
Port improvements from start_civ to VM manager by @prashanth-intel in projectceladon#252 Disable sound card emulation option by @blackdobb in projectceladon#253 Match correct value for support_suspend by @blackdobb in projectceladon#254 Update action version by @yadong-intel in projectceladon#258 Update the SRIOV fw for kernel 5.15 host by @yhe39 in projectceladon#255 Fix deadlock issue by @yadong-intel in projectceladon#257 Fixed android boot failed by rpmb socket by @blackdobb in projectceladon#268 added format setting steps in camera setup scripts by @shivasku82 in projectceladon#265 Fix GuC loading failing on ubuntu host side by @JeevakaPrabu in projectceladon#272 Disable net emulation when net.model==none by @yadong-intel in projectceladon#274 Tracked-On: OAM-105251 Signed-off-by: Yadong Qi <yadong.qi@intel.com>
Tracked-On: OAM-104956
Signed-off-by: blackdobb xinxin.wan@intel.com