Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #326

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Fixes #326

merged 4 commits into from
Mar 30, 2023

Conversation

yadong-intel
Copy link
Contributor

@yadong-intel yadong-intel commented Mar 30, 2023

Add try{...}catch{...} to handle exception handling.
Move null check ahead
return when open failed
Fix invalid compare

Signed-off-by: Yadong Qi yadong.qi@intel.com

@yadong-intel yadong-intel requested a review from YadongQi as a code owner March 30, 2023 02:25
@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/141/

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/141/

@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/PR/5fab05a

@YadongQi YadongQi changed the title Handle uncaught exceptions Fixes Mar 30, 2023
@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/142/

@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/143/

@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/144/

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/144/

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/142/

@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/PR/70435ab

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/143/

@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/PR/70435ab

1 similar comment
@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/PR/70435ab

@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/145/

Add try{...}catch{...} to handle exception handling.

Signed-off-by: Yadong Qi <yadong.qi@intel.com>
In the SetProcLogDir(), main_proc_ would be deferenced,
so move the null pointer check before call SetProcLogDir().

Signed-off-by: Yadong Qi <yadong.qi@intel.com>
when open() return negative, there should no close followed,
instead, return fail directly.

Signed-off-by: Yadong Qi <yadong.qi@intel.com>
The value will never be negative

Signed-off-by: Yadong Qi <yadong.qi@intel.com>
@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/146/

@sysopenci
Copy link

Building VM-Manager Code. For more details refer below link:
job/satg-aee-android-ci/job/VM-MANAGER-PR-MERGE-FLOW/100/

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/145/

@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/PR/ec08d7b

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-FLOW/146/

@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/PR/0902309

@sysopenci
Copy link

Build successful.
job/satg-aee-android-ci/job/VM-MANAGER-PR-MERGE-FLOW/100/

@sysopenci
Copy link

Please find the Deb Package Path :
artifactory/dev-automation-ba-local/vm-manager-binaries/326/MR/0902309

@sysopenci sysopenci merged commit 42bba31 into projectceladon:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants