Upgrade docsearch to v3 #5129
Merged
Upgrade docsearch to v3 #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnbrown
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
|
Closes #5086 |
pnbrown
force-pushed
the
update-search
branch
from
4661936
to
82815fc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5129 +/- ##
==========================================
+ Coverage 77.97% 78.02% +0.04%
==========================================
Files 137 138 +1
Lines 17237 17517 +280
==========================================
+ Hits 13441 13668 +227
- Misses 3536 3583 +47
- Partials 260 266 +6
|
pnbrown
added
area/website
sunjayBhatia
added
release-note/none-required
|
docs release note guidelines here: https://github.com/projectcontour/contour/blob/main/changelogs/unreleased/docs-sample.md something simple like "Upgrade algolia docsearch to v3" should be good |
|
looks like it is working on the deploy preview: https://deploy-preview-5129--projectcontour.netlify.app/ |
Yep, preview looks great to me, the updated UI seems pretty nice! |
pnbrown
force-pushed
the
update-search
branch
from
82815fc
to
c032d55
Compare
skriss
reviewed
Feb 28, 2023
Updating docsearch to fix the search functionality on the site Signed-off-by: Nigel Brown <nigelb@vmware.com>
pnbrown
force-pushed
the
update-search
branch
from
c032d55
to
dd4dbe8
Compare
sunjayBhatia
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating docsearch to fix the search functionality on the site