Automatically set GOMAXPROCS to match the number of CPUs available to the container #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatvig
added
the
release-note/small
rajatvig
requested review from
tsaarni and
skriss
and removed request for
a team
… the container Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5211 +/- ##
==========================================
- Coverage 77.94% 77.85% -0.09%
==========================================
Files 138 138
Lines 17731 17759 +28
==========================================
+ Hits 13820 13826 +6
- Misses 3646 3665 +19
- Partials 265 268 +3
|
|
Unsure how to go about fixing the code coverage drop. |
Signed-off-by: Rajat Vig <rvig@etsy.com>
sunjayBhatia
requested changes
Mar 23, 2023
There was a problem hiding this comment.
lgtm other than the one comment
logs look like this with no resources defined:
time="2023-03-23T13:39:58Z" level=info msg="maxprocs: Leaving GOMAXPROCS=8: CPU quota undefined"
when defined:
time="2023-03-23T13:43:42Z" level=info msg="maxprocs: Updating GOMAXPROCS=1: determined from CPU quota"
when set in the environment:
time="2023-03-23T13:49:02Z" level=info msg="maxprocs: Honoring GOMAXPROCS=\"4\" as set in environment"
Signed-off-by: Rajat Vig <rvig@etsy.com>
sunjayBhatia
approved these changes
Mar 24, 2023
skriss
approved these changes
Mar 24, 2023
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
… the container (projectcontour#5211) Closes projectcontour#5022. Signed-off-by: Rajat Vig <rvig@etsy.com>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
… the container (projectcontour#5211) Closes projectcontour#5022. Signed-off-by: Rajat Vig <rvig@etsy.com> Signed-off-by: yy <yang.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5023 to address #5022