-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix JSON file output #183
fix JSON file output #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we do a lot of work:
Response => Result => Slice of results with manual marshaling => json line
Probably we can refactor the code so that each response mapped to a result results in a json line directly:
Response => intializeResult => Result => json line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation: lgtm
tests fail because API gives 502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- asnmap
-j
option write output in json format, we can update it write in json line format to keep it uniform like other pd tools. - when
-j
option is used with-o
, output gets written to only file but not displayed to stdout like other pd tools, we can fix that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI output gets written to file but not visible to stdout.
./asnmap -a AS20940 -o test
Closes #176.