Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading keys from environment variables #249

Closed
ehsandeep opened this issue Nov 11, 2022 Discussed in #248 · 0 comments · Fixed by #257 or #260
Closed

Reading keys from environment variables #249

ehsandeep opened this issue Nov 11, 2022 Discussed in #248 · 0 comments · Fixed by #257 or #260
Assignees
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@ehsandeep
Copy link
Member

ehsandeep commented Nov 11, 2022

Discussed in #248

Originally posted by omarkurt November 11, 2022
Hello PD team,
I want to use environment variables instead of adding them in the configuration file as plaintext.

For example,

- provider: aws 
  id: staging
  aws_access_key: $ACCESS_KEY
  aws_secret_key: $SECRET_KEY

I did not see any information regarding using ENV variables.


Note:

Probably support to add in https://github.com/projectdiscovery/goflags so all other PD projects can utilize this enhancement.

@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. Priority: Medium This issue may be useful, and needs some attention. labels Nov 11, 2022
@parrasajad parrasajad self-assigned this Nov 14, 2022
@parrasajad parrasajad linked a pull request Nov 15, 2022 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 27, 2022
@ehsandeep ehsandeep linked a pull request Nov 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
2 participants