Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading keys from environment variables #245

Closed
ehsandeep opened this issue Apr 16, 2023 · 0 comments · Fixed by #249
Closed

Reading keys from environment variables #245

ehsandeep opened this issue Apr 16, 2023 · 0 comments · Fixed by #249
Assignees
@ShubhamRasal
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
notify v1.0.5

Comments

@ehsandeep
Copy link
Member

Similar to

Please describe your feature request:

Allow reading reporting config values from as env variable to avoid storing sensitive keys/credentials as plain text in a reporting and flag config file.

$ cat config.yaml

slack:
  - id: recon
    slack_channel: $SLACK_CHANNEL
    slack_username: $SLACK_USER
    slack_webhook_url: $SLACK_WEBHOOK

Describe the use case of this feature:

cat output | notify -pc config.yaml
@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Apr 16, 2023
@ehsandeep ehsandeep added this to the notify v1.0.5 milestone Apr 16, 2023
@ShubhamRasal ShubhamRasal self-assigned this Apr 20, 2023
@ehsandeep ehsandeep linked a pull request Apr 27, 2023 that will close this issue
Set provider config from ENV vars instead of plain text files #249
Merged
6 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label May 27, 2023
@ehsandeep ehsandeep mentioned this issue Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShubhamRasal ShubhamRasal

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
notify v1.0.5
Development

Successfully merging a pull request may close this issue.

Set provider config from ENV vars instead of plain text files
2 participants
@ehsandeep @ShubhamRasal