Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix route53 hosted zone enumeration panic #394

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix route53 hosted zone enumeration panic #394

merged 1 commit into from
Sep 14, 2023

Conversation

mionskowski-form3
Copy link
Contributor

@mionskowski-form3 mionskowski-form3 commented Aug 10, 2023 •
edited
Loading

route53 zone enumeration would panic if the response was truncated.

This PR fixes it by using the correct response property NextMarker instead of Marker.

@ehsandeep ehsandeep changed the base branch from main to dev August 10, 2023 12:34
@mionskowski-form3
fix route53 hosted zone enumeration panic
cace48d 
route53 zone enumeration would panic if the response was truncated.
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mionskowski-form3
Copy link
Contributor Author

Apologies for submitting this against main instead of dev. I rebased this on top of dev and force-pushed the changes to resolve the conflicts.

@ehsandeep ehsandeep removed the request for review from ShubhamRasal September 14, 2023 12:39
@ehsandeep ehsandeep merged commit bd31279 into projectdiscovery:dev Sep 14, 2023
8 checks passed
@Porkepix Porkepix mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mionskowski-form3 @ehsandeep