gcp: Modify GCP provider to fallback to ADC if gcp_service_account_key is not set [#531]
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey` is not set [projectdiscovery#531] This change updates the authentication logic in the GCP provider to fallback and use [application default credentials](https://cloud.google.com/docs/authentication/provide-credentials-adc) when authenticating with GCP instead of requiring that `gcp_service_account_key` be set in the provider configuration. Using ADC by default is the default behavior for the Google Cloud SDK and most applications that call GCP APIs.
Ice3man543
approved these changes
Jun 25, 2024
ShubhamRasal
approved these changes
Jun 25, 2024
ehsandeep
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the authentication logic in the GCP provider to fallback and use application default credentials when authenticating with GCP instead of requiring that
gcp_service_account_keybe set in the provider configuration. Using ADC by default is the default behavior for the Google Cloud SDK and most applications that call GCP APIs.Using ADC also allows
cloudlistto authenticate with GCP using temporary credentials when running on workloads in GCP instead of using static credentials (something Google recommends against).