Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registering hostname with ip in DailerHistory #314

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Fix registering hostname with ip in DailerHistory #314

merged 3 commits into from
Jul 11, 2024

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jul 10, 2024 •
edited
Loading

@RamanaReddy0M RamanaReddy0M self-assigned this Jul 10, 2024
@RamanaReddy0M RamanaReddy0M linked an issue Jul 10, 2024 that may be closed by this pull request
Failed to register hostIp in DialerHistory #313
Closed
@RamanaReddy0M RamanaReddy0M mentioned this pull request Jul 10, 2024
Merged
tarunKoyalwar
tarunKoyalwar approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch !

lgtm !

tarunKoyalwar
tarunKoyalwar requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is one of core feature in nuclei and httpx as well , we can add a unit test in tests/fastdialer_test.go on

scanme.sh -> resolves to one ip
projectdiscovery.io -> resolves to multiple ips

tarunKoyalwar
tarunKoyalwar approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@tarunKoyalwar tarunKoyalwar merged commit 033b71c into main Jul 11, 2024
5 checks passed
@tarunKoyalwar tarunKoyalwar deleted the issue-313-bug-dialer-history branch July 11, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to register hostIp in DialerHistory
2 participants
@RamanaReddy0M @tarunKoyalwar