Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileStringSliceOption read the cli input as rawstring if not file #101

Merged
merged 6 commits into from
Nov 24, 2022
Merged

FileStringSliceOption read the cli input as rawstring if not file #101

merged 6 commits into from
Nov 24, 2022

Conversation

ShubhamRasal
Copy link
Contributor

@ShubhamRasal ShubhamRasal commented Nov 22, 2022 •
edited
Loading

  • Add new variable RawString to options interface
  • option should read the string input as it is from the cli if it is not file
  • If it is file then read the file with new line separator
  • FileStringSliceOptions
    • If file then read the file
    • if not add the input to the slice as it is.

@ShubhamRasal ShubhamRasal self-assigned this Nov 22, 2022
@ShubhamRasal ShubhamRasal marked this pull request as draft November 22, 2022 11:43
@ShubhamRasal
Merge branch 'main' into check_comma_in_quotes
defc007
@ShubhamRasal
Add as a raw string if not file for FileStringSliceOptions
bf6e5cc 
- If input is FileStringSliceOptions then it will only accept filename
  or string input. (not a list of input seperated by commas)
- Adding this RawString as boolean flag in options
- Set above flag as true for FileStringSliceOptions
ShubhamRasal added a commit to projectdiscovery/uncover that referenced this pull request Nov 23, 2022
@ShubhamRasal
Update goflag version to point to commit which fix the ','
75c9fd8 
- projectdiscovery/goflags#101
@ShubhamRasal ShubhamRasal mentioned this pull request Nov 23, 2022
Merged
@ShubhamRasal ShubhamRasal changed the title Check comma inside quotes before spliting [WIP] FileStringSliceOption read the cli input as rawstring if not file Nov 23, 2022
@ShubhamRasal ShubhamRasal added the Status: In Progress This issue is being worked on, and has someone assigned. label Nov 23, 2022
@ShubhamRasal ShubhamRasal marked this pull request as ready for review November 23, 2022 11:05
@ShubhamRasal ShubhamRasal added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 23, 2022
Mzack9999
Mzack9999 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - pending:

@Mzack9999 Mzack9999 merged commit 4a427c3 into main Nov 24, 2022
@Mzack9999 Mzack9999 deleted the check_comma_in_quotes branch November 24, 2022 07:57
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 24, 2022
ehsandeep pushed a commit to projectdiscovery/uncover that referenced this pull request Nov 24, 2022
@ShubhamRasal
Update goflag version to solve spliting at ',' for FileStringSliceOpt…
bcd2d1a 
…ion (#111)

* Update goflag version to point to commit which fix the ','

- projectdiscovery/goflags#101

* Bump goflags version v0.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@ShubhamRasal ShubhamRasal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamRasal @Mzack9999 @ehsandeep