Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-ss flag does not support custom header input with -H option #1784

Closed
humblelad opened this issue Jun 24, 2024 · 1 comment · Fixed by #1785
Closed

-ss flag does not support custom header input with -H option #1784

humblelad opened this issue Jun 24, 2024 · 1 comment · Fixed by #1785
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone

Comments

@humblelad
Copy link

httpx version: v1.6.5

v1.6.5 Yes

Current Behavior:

Suppose I use the below command to take screenshot, the SS generated shows login page instead of for example logged in dashboard.
httpx -l done.txt -title -status-code -H "Cookie:xyz" -mc 200 -ss

Expected Behavior:

Ideally , since i supply cookies in headers and also get valid 200 response in the reponse back, httpx should take screenshot of that page rather than headless chromium taking screenshot of login page.

Steps To Reproduce:

Example: steps to reproduce the behavior:

  1. Run ' httpx -l done.txt -title -status-code -H "Cookie:xyz" -mc 200 -ss
    where done.txt may have example.com which has logged in dashboard if we supply cookes in headers like auth token. So -ss should take screenshot of logged in view not , login page.

Anything else:

@humblelad humblelad added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 24, 2024
@ehsandeep ehsandeep changed the title -ss flag takes screenshot without considering Headers. -ss flag does not support custom header input with -H option Jun 24, 2024
@dogancanbakir dogancanbakir self-assigned this Jun 25, 2024
@dogancanbakir dogancanbakir linked a pull request Jun 25, 2024 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jun 26, 2024
@ehsandeep
Copy link
Member

@humblelad this is now fixed in dev version with #1785 and will be part of next release, thanks for creating issue for it.

@ehsandeep ehsandeep added this to the httpx - v1.6.6 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants