Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom header support for screenshot #1785

Merged
merged 1 commit into from
Jun 26, 2024
Merged

add custom header support for screenshot #1785

merged 1 commit into from
Jun 26, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1784

@dogancanbakir dogancanbakir self-assigned this Jun 25, 2024
@dogancanbakir dogancanbakir linked an issue Jun 25, 2024 that may be closed by this pull request
-ss flag does not support custom header input with -H option #1784
Closed
Mzack9999
Mzack9999 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

$ go run . -u http://192.168.5.1 -title -status-code -nfs -H "Cookie:xyz" -ss -v
...
[DBG] automatically enabling store response
[DBG] Store response directory not specified, using "output"
http://192.168.5.1 [200]
Screenshot 2024-06-26 at 07 38 53

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 26, 2024
@ehsandeep ehsandeep merged commit 19ccde1 into dev Jun 26, 2024
11 checks passed
@ehsandeep ehsandeep deleted the custom_header_support_for_screenshot branch June 26, 2024 09:42
@ehsandeep ehsandeep mentioned this pull request Jun 26, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-ss flag does not support custom header input with -H option
3 participants
@dogancanbakir @ehsandeep @Mzack9999