Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats (scan progress) doesn't properly calculate hosts/percentage when there are multiple probe paths #1841

Closed
hourianto opened this issue Jul 26, 2024 · 1 comment · Fixed by #1870
Closed

Stats (scan progress) doesn't properly calculate hosts/percentage when there are multiple probe paths #1841

hourianto opened this issue Jul 26, 2024 · 1 comment · Fixed by #1870
Assignees
@dogancanbakir
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@hourianto
Copy link

httpx version:

1.6.6

Current Behavior:

If you provide multiple paths with -path probe_paths.txt when scanning, httpx will misreport progress:

[0:47:55] | RPS: 0 | Requests: 572528 | Hosts: 332392/41549 (800%)

In this case it's 800% because my probe_paths.txt has 8 paths.

Expected Behavior:

Stats calculation should take the amount of paths into the account when calculating Hosts and progress percentage.

Steps To Reproduce:

Start any httpx scan with -path probe_paths.txt -stats with probe_paths.txt containing more than 1 path.
@hourianto hourianto added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 26, 2024
@dogancanbakir dogancanbakir self-assigned this Jul 29, 2024
@dogancanbakir dogancanbakir mentioned this issue Aug 12, 2024
Merged
@dogancanbakir dogancanbakir linked a pull request Aug 12, 2024 that will close this issue
fix stat calc #1870
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 12, 2024
@ehsandeep
Copy link
Member

This is now fixed in latest release - https://github.com/projectdiscovery/httpx/releases/tag/v1.6.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix stat calc projectdiscovery/httpx
4 participants
@ehsandeep @Mzack9999 @dogancanbakir @hourianto