Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stat calc #1870

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix stat calc #1870

merged 1 commit into from
Aug 12, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1841

@dogancanbakir dogancanbakir self-assigned this Aug 12, 2024
@dogancanbakir dogancanbakir linked an issue Aug 12, 2024 that may be closed by this pull request
Stats (scan progress) doesn't properly calculate hosts/percentage when there are multiple probe paths #1841
Closed
Mzack9999
Mzack9999 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ cat targets.txt 
192.168.5.0/24
192.168.10.0/24
$ cat paths.txt 
/a
/b
/c
$ cat targets.txt | go run . -path paths.txt -stats -rl 1
...
[0:00:05] | RPS: 0 | Requests: 3 | Hosts: 51/1536 (3%)

@Mzack9999 Mzack9999 merged commit 35a9961 into dev Aug 12, 2024
11 checks passed
@Mzack9999 Mzack9999 deleted the fix_stat_calc branch August 12, 2024 19:22
@BrewTestBot BrewTestBot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stats (scan progress) doesn't properly calculate hosts/percentage when there are multiple probe paths
2 participants
@dogancanbakir @Mzack9999