Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nil pointer dereference when probing ips of unresolved host #1033

Merged
merged 2 commits into from
Mar 13, 2023
Merged

fix nil pointer dereference when probing ips of unresolved host #1033

merged 2 commits into from
Mar 13, 2023

Conversation

freimer
Copy link
Contributor

@freimer freimer commented Mar 12, 2023

function was continuing to process even when there was an error and URL was nil. Return after sending results if there is no data to process.

Fixes #977

ehsandeep and others added 2 commits March 12, 2023 17:41
@ehsandeep
Merge pull request projectdiscovery#1032 from projectdiscovery/dev
a07f839 
httpx v1.2.8
@freimer
Fix 977
eab3aec 
function was continuing to process even when there was an error and
URL was nil.  Return after sending resuilts if there is no data to
process.
@ehsandeep ehsandeep changed the base branch from main to dev March 13, 2023 08:04
@tarunKoyalwar tarunKoyalwar changed the title Fix 977 fix nil pointer dereference when probing ips of unresolved host Mar 13, 2023
tarunKoyalwar
tarunKoyalwar approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

$ ./httpx -u https._tcp.cloud.asdf.com -pa       

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/              v1.2.8

		projectdiscovery.io

@ehsandeep ehsandeep merged commit c67bf20 into projectdiscovery:dev Mar 13, 2023
@freimer freimer deleted the fix-977 branch March 15, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash - invalid memory address or nil pointer dereference
3 participants
@freimer @ehsandeep @tarunKoyalwar