Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output response fields public #1266

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

jnovikov
Copy link
Contributor

@jnovikov jnovikov commented Jul 2, 2023

Make output response fields public so they can be specified if httpx used as a library.

These field are directly set by CLI flags but it's impossible to specify them if httpx used as a Go library. This PR should fix this.

@ehsandeep ehsandeep changed the base branch from main to dev July 3, 2023 07:46
@ehsandeep ehsandeep requested a review from Mzack9999 July 17, 2023 11:49
@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jul 19, 2023
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The fields responseInStdout and base64responseInStdout should be exported
3 participants