fix missing favicon hash for targets #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RamanaReddy0M
commented
Jul 31, 2024
•
RamanaReddy0M
commented
- closes Add support more favicon types (-favicon mmh3 probe enchant) #1842
✗ ./httpx -u "https://0-cenka.ru,https://0360.ru,https://www.viber.com,https://favicon.io/emoji-favicons/alien/,https://00j.ru/" -favicon -fr -fhr
__ __ __ _ __
/ /_ / /_/ /_____ | |/ /
/ __ \/ __/ __/ __ \| /
/ / / / /_/ /_/ /_/ / |
/_/ /_/\__/\__/ .___/_/|_|
/_/
projectdiscovery.io
[INF] Current httpx version v1.6.6 (latest)
[WRN] UI Dashboard is disabled, Use -dashboard option to enable
https://www.viber.com [https://www.viber.com/en/] [1550133834]
https://favicon.io/emoji-favicons/alien/ [1352067985]
https://00j.ru/ [1871456111]
https://0360.ru [-1805840784]
https://0-cenka.ru [-1211857331] |
tarunKoyalwar
requested review from
dwisiswant0
and removed request for
tarunKoyalwar
dwisiswant0
requested changes
Aug 5, 2024
There was a problem hiding this comment.
I'm not really sure if this is a practical step to perform a check using a "data:image/" prefix instead of validating the whole mimetype with a ^data:(image\/.+);base64, pattern. Or maybe, we could use mime.ParseMediaType to dodge issues with invalid chars/padding and to future-proof our code against possible MIME type variants.
dwisiswant0
approved these changes
Aug 7, 2024
RamanaReddy0M
force-pushed
the
issue-1842-fix-missing-favicon-hashes
branch
from
56b9973
to
85ad210
Compare
ehsandeep
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.