Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving paths loading from file #483

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Improving paths loading from file #483

merged 2 commits into from
Jan 10, 2022

Conversation

Mzack9999
Copy link
Member

This PR improves the implicit logic handling paths loading from a file when a raw but valid path provided via CLI indirectly also points to a local file. Assuming that the user would give the shortest path pointing to an existing local file if the cleaned provided path doesn't match the calculated one, the path is used directly in the request.

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 10, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 10, 2022
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 10, 2022
@ehsandeep ehsandeep merged commit f5935eb into dev Jan 10, 2022
@ehsandeep ehsandeep deleted the issue-480-paths-from-file branch January 10, 2022 11:11
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: runtime error: invalid memory address or nil pointer dereference
2 participants