Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to avoid reuse in github env #32

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

fguisso
Copy link
Contributor

@fguisso fguisso commented Mar 14, 2022

This fixes a problem with concatenating PDActions.

You can test using naabu + nuclei or something another action, that parameters with same name export to GITHUB_ENV can't be updated, leaving us with the first input attribution, cause some errors.

Copy link
Contributor

@toufik-airane toufik-airane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. 👀
I approve the merge.

Thank you for your work! 👏

@fguisso
Copy link
Contributor Author

fguisso commented Mar 16, 2022

@toufik-airane probably we need to do that in all another PDActions, I can commit in all others repository if you accept this resolution.

I don't think this is the best solution, but probably a better solution is rewrite all actions using the javascript SDK for GitHub Actions. I had proposed this think about GITHUB_ENV in the past, then I compromise to update, but in a long-term.

@toufik-airane
Copy link
Contributor

Hey @fguisso,

Great idea! It could be an awesome initiative to extend the longevity of the Actions.
What do you think about working on those changes in different branches and coordinating on Discord (Toufik Airane#1048)?

Regards.

@ehsandeep ehsandeep merged commit 8593cd0 into projectdiscovery:main Apr 19, 2022
@ehsandeep
Copy link
Member

Thank you, @fguisso, looks like we can make similar changes to other projects as well.

@fguisso fguisso deleted the inputs branch April 19, 2022 15:19
@fguisso
Copy link
Contributor Author

fguisso commented Apr 19, 2022

@ehsandeep I'm studying the Github Actions Toolkit, it seems to be a fancier way to resolve this problem and avoid using GITHUB_ENV. I'll try to show you a refac until the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants