Cache nuclei to toolcache dir. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems useful. Can this move forward? |
|
Docs on this here: https://github.com/actions/toolkit/tree/main/packages/tool-cache#cache This would allow us not only to check to cache, but save files to the cache, and skip needing to redownload/reinstall Nuclei every single time we run actions. |
RamanaReddy0M
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
On second run used the cached nuclei binary, Instead of downloading new one.
Test Ref: https://github.com/RamanaReddy0M/workflow-test/actions/runs/8264730056/job/22608933270
lgtm!
|
Thank you so much! This is going to help our test speed significantly, as we run many stages of Nuclei tests internally and they each call the action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cacheFile to cache nuclei.