Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to Node v20 #79

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Upgrades to Node v20 #79

merged 1 commit into from
Mar 13, 2024

Conversation

felipesaezreyes
Copy link
Contributor

@felipesaezreyes felipesaezreyes commented Mar 6, 2024 •
edited
Loading

This PR upgrades from Node 16 to 20 in the action.yml file.

I tested this in my environment and it works fine.

@felipesaezreyes felipesaezreyes changed the title Update to Node v20 Upgrades to Node v20 Mar 6, 2024
@ehsandeep ehsandeep requested a review from RamanaReddy0M March 6, 2024 19:37
tibbon
tibbon reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@tibbon tibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd very much enjoy this, given node16 is deprecated and throwing warnings

@RamanaReddy0M RamanaReddy0M linked an issue Mar 13, 2024 that may be closed by this pull request
Node20 #74
Closed
RamanaReddy0M
RamanaReddy0M approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Ref: https://github.com/RamanaReddy0M/workflow-test/actions/runs/8265067395/job/22609936646

lgtm!

@ehsandeep ehsandeep merged commit 8c1e8ef into projectdiscovery:main Mar 13, 2024
@felipesaezreyes felipesaezreyes deleted the nodev20 branch March 13, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibbon tibbon tibbon left review comments

@RamanaReddy0M RamanaReddy0M RamanaReddy0M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node20
4 participants
@felipesaezreyes @tibbon @RamanaReddy0M @ehsandeep