Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added websocket and SSL protocol support + engine refactor #1066

Merged
merged 51 commits into from
Nov 11, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Sep 29, 2021

Cross site websocket hijacking

id: cswsh

info:
  name: cswsh
  description: cswsh
  author: pdteam
  severity: low

websocket:
  - address: '{{Scheme}}://{{Hostname}}{{Path}}'
    headers: 
      Origin: 'http://evil.com'
    matchers:
      - type: word
        words:
          - true
        part: success

Websocket communication template

id: websocket-test-1

info:
  name: websocket-test-1
  description: websocket-test-1
  author: pdteam
  severity: low

websocket:
  - address: '{{Scheme}}://{{Hostname}}{{Path}}'
    inputs:
      - data: '{"secret":"{{value}}"}'
    payloads:
      value:
        - "test"
        - "actual"
    matchers:
      - type: word
        words: 
          - "success"
        part: response

Expired SSL Cert

id: expired-ssl

info:
  name: expired-ssl
  description: expired-ssl
  author: pdteam
  severity: low

ssl:
  - address: "{{Hostname}}"
    matchers:
      - type: dsl
        dsl: 
          - "unixtime() > not_after"
        part: response

@ehsandeep ehsandeep linked an issue Sep 30, 2021 that may be closed by this pull request
@ehsandeep ehsandeep added the Status: In Progress This issue is being worked on, and has someone assigned. label Oct 11, 2021
@Ice3man543 Ice3man543 changed the base branch from dev to engine-execution October 30, 2021 20:46
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We can expose all the raw SSL data to nuclei engine (preferably JSON similar to zgrab2) that will allow users to model any desired template, for example - Network enhancement Certificate SSL check #797
  • Debug support to SSL Protocol
  • Global variables for SSL protocol {{Hostname}}, {{Host}}, {{Port}}
  • Websocket - Updating {{Address}} to {{Hostname}} to keep it uniform across other protocol

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 8, 2021
@forgedhallpass forgedhallpass linked an issue Nov 8, 2021 that may be closed by this pull request
@ehsandeep ehsandeep linked an issue Nov 10, 2021 that may be closed by this pull request
3 tasks
@ehsandeep ehsandeep linked an issue Nov 10, 2021 that may be closed by this pull request
3 tasks
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response is not the default part of the SSL protocol

Test SSL template
id: test-ssl

info:
  name: test-ssl
  description: test-ssl
  author: pdteam
  severity: info

ssl:
  - address: "{{Hostname}}"

    extractors:
      - type: json
        json:
          - ".dns_names[]"
echo https://example.com | ./nuclei -t test.yaml

@ehsandeep ehsandeep added the Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. label Nov 10, 2021
@Ice3man543 Ice3man543 merged commit 304b639 into dev Nov 11, 2021
@Ice3man543 Ice3man543 deleted the more-protocols branch November 11, 2021 23:15
@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Nov 12, 2021
@ehsandeep ehsandeep linked an issue Nov 15, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
4 participants