Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing eq sign #4513

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix missing eq sign #4513

merged 1 commit into from
Dec 20, 2023

Conversation

dogancanbakir
Copy link
Member

Proposed changes

Closes #4512.

$ cat test.yaml
id: CVE-2023-XXXXX
info:
  name: XXX
  author: foo
  severity: high
variables:
  path: '/lol.php?param1=foo&param2=&param3=bar'
http:
  - raw:
      - |
        GET /{{path}} HTTP/1.1
        Host: {{Hostname}}
        Connection: close

        # 
    unsafe: true
    req-condition: true

$ go run . -t ./test.yaml -u http://example.com --dreq

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v3.1.2

                projectdiscovery.io

[INF] Current nuclei version: v3.1.2 (latest)
[INF] Current nuclei-templates version: v9.7.1 (latest)
[WRN] Scan results upload to cloud is disabled.
[INF] New templates added in latest release: 0
[INF] Templates loaded for current scan: 1
[WRN] Executing 1 unsigned templates. Use with caution.
[INF] Targets loaded for current scan: 1
[INF] [CVE-2023-XXXXX] Dumped HTTP request for http://example.com//lol.php?param1=foo&param2=&param3=bar

GET //lol.php?param1=foo&param2=&param3=bar HTTP/1.1
Host: example.com
Connection: close

# 
[INF] No results found. Better luck next time!

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dogancanbakir dogancanbakir self-assigned this Dec 19, 2023
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

maybe we could have enabled this implicitly for all requests since this will be another edgecase to maintain but not sure if it would break any existing templates

@ehsandeep ehsandeep merged commit e6133ef into dev Dec 20, 2023
12 checks passed
@ehsandeep ehsandeep deleted the fix_missing_eq_sign branch December 20, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing '=' in RAW Request with URL Path Variable
3 participants