Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resume file creation issue #4514

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Dec 19, 2023

Proposed changes

Closes #4508

go run . -u scanme.sh

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v3.1.2

                projectdiscovery.io

^C[INF] CTRL+C pressed: Exiting
[INF] Creating resume file: /Users/dogancanbakir/Library/Caches/nuclei/resume-cm0jg3va2ua68d58qcj0.cfg
exit status 1

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dogancanbakir dogancanbakir self-assigned this Dec 19, 2023
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

maybe we should have a util for this in fileutil like MkDirIfNotExist(path string) or something similar . this feels like a common occurence

@ehsandeep ehsandeep merged commit d07f31f into dev Dec 20, 2023
12 checks passed
@ehsandeep ehsandeep deleted the fix_resume_file_creation_issue branch December 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't create resume file
3 participants