Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(raw&fuzzing): Fix duplicate query parameter. Allow fuzzing query from raw template #4519

Closed
wants to merge 1 commit into from

Conversation

n00b-bot
Copy link

@n00b-bot n00b-bot commented Dec 20, 2023

  • Refactored the Parse function in pkg/protocols/http/raw/raw.go to simplify the URL parsing and modification logic.
  • Created a cloned variable to clone the input URL for further modifications.
  • Removed unnecessary cloning of the input URL in multiple places.
  • Improved code readability and removed redundant code.

These changes make the URL parsing and modification logic more concise and easier to understand.

Proposed changes

Change Fuzzing template only received from input and fix duplicate query parameters from input
Fixes #4494

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

- Refactored the `Parse` function in `pkg/protocols/http/raw/raw.go` to simplify the URL parsing and modification logic.
- Created a `cloned` variable to clone the input URL for further modifications.
- Removed unnecessary cloning of the input URL in multiple places.
- Improved code readability and removed redundant code.

These changes make the URL parsing and modification logic more concise and easier to understand.
@n00b-bot n00b-bot changed the title refactor(http): simplify URL parsing and modification logic refactor(raw&fuzzing): Fix duplicate query parameter. Allow fuzzing query from raw template Dec 20, 2023
@tarunKoyalwar
Copy link
Member

superseeded by #4477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Query Parameter
2 participants