Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SourceIP in NetworkConfig (SDK) #4566

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Add SourceIP in NetworkConfig (SDK) #4566

merged 2 commits into from
Jan 7, 2024

Conversation

Anemys
Copy link
Contributor

@Anemys Anemys commented Jan 3, 2024 •
edited
Loading

Proposed changes

This PR adds ability to define scan source IP when creating a Nuclei Engine.
It completes this issue #4409.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep merged commit 9b2b7ad into projectdiscovery:dev Jan 7, 2024
12 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar Awaiting requested review from tarunKoyalwar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anemys @ehsandeep