Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass exclude list to layer 4 fast dialer #4575

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 4, 2024

Proposed changes

Propagate exclusion list to fastdialer

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Example

$ cat /etc/hosts
192.168.10.1 bingo.bongo

$ go run . -id tech-detect -u http://bingo.bongo/ -eh 192.168.10.0/24 -v
...
[WRN] [tech-detect] Could not execute request for http://bingo.bongo/: GET http://bingo.bongo/ giving up after 2 attempts: Get "http://bingo.bongo/": denied address found for host
[INF] No results found. Better luck next time!
Screenshot 2024-01-05 at 12 24 11

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 4, 2024
@Mzack9999 Mzack9999 self-assigned this Jan 4, 2024
@Mzack9999 Mzack9999 marked this pull request as ready for review January 5, 2024 11:39
@Mzack9999 Mzack9999 requested a review from Ice3man543 January 5, 2024 11:40
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mzack9999 Mzack9999 merged commit 342cc56 into dev Jan 5, 2024
12 checks passed
@Mzack9999 Mzack9999 deleted the feat-fastdialer-exclude branch January 5, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants