Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc improvements in js protocol execution #4643

Merged
merged 6 commits into from
Jan 17, 2024
Merged

misc improvements in js protocol execution #4643

merged 6 commits into from
Jan 17, 2024

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Jan 15, 2024

Proposed Changes

  • fix infinite hang on smbInfo ( retry with smbv1) (ref: https://github.com/projectdiscovery/aurora/issues/508)
  • Global Javascript protocol script execution control using -timeout flag
  • Custom timeout field in javascript protocol (allowed with sane limits 10 < timeout < 180s)
  • default timeout of 6 * -timeout in code protocol
$  ./nuclei -t a.yaml -v -svd -timeout 2 -code      

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v3.1.5

		projectdiscovery.io

[VER] Started metrics server at localhost:9092
[INF] Current nuclei version: v3.1.5 (latest)
[INF] Current nuclei-templates version: v9.7.3 (latest)
[WRN] Scan results upload to cloud is disabled.
[INF] New templates added in latest release: 46
[INF] Templates loaded for current scan: 1
[INF] Executing 1 signed templates from tarun
[VER] [py-code-snippet] Executed code on local machine 
[DBG] Code Protocol request variables: 
	1. Hostname => 
	2. Input => 

[DBG] Code Protocol response variables: 
	1. input => 
	2. interactsh-server => 
	3. response => 
	4. stderr => context deadline exceeded
	5. template-id => py-code-snippet
	6. template-info => {py-code-snippet pdteam c .... nil> {info} map[] <nil> }
	7. template-path => /Users/tarun/Codebase/nuclei/a.yaml
	8. type => code

[py-code-snippet:error] [code] [info]  ["context deadline exceeded"]

@tarunKoyalwar tarunKoyalwar self-assigned this Jan 15, 2024
@tarunKoyalwar tarunKoyalwar changed the title js protocol timeout using -timeout flag misc improvements in js protocol execution Jan 15, 2024
@tarunKoyalwar tarunKoyalwar linked an issue Jan 15, 2024 that may be closed by this pull request
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review January 15, 2024 14:31
@tarunKoyalwar tarunKoyalwar requested review from dogancanbakir and removed request for Ice3man543 January 16, 2024 14:18
@ehsandeep ehsandeep merged commit a677fca into dev Jan 17, 2024
12 checks passed
@ehsandeep ehsandeep deleted the js-misc-fixes branch January 17, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js: smb template gets stuck without any deadline
2 participants