-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent Memoization via func Annotation #4742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Enhancement
Most issues will probably ask for additions or changes.
label
Feb 21, 2024
tarunKoyalwar
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
i think all of known independent heavy functions are memoized. with scan logs we will be able to identify and memoize more of them
ehsandeep
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements a transparent memoization mechanism via functions annotations and AST parsing, requiring no changes within the codebase other than replacing
package.Function(xx)
withmemo.Function(xx)
(memo
is the newly generated package with memoized functions).A function to memoize should be annotated in the following way:
The new utility parses the go files and within a new destination package creates corresponding files exposing the same functions signature, but wrapped within a memoization mechanism:
sync.Once
that automatically declares local variables to store arbitrary return values, capture in-flight requests and return the resultPros:
Checklist
Example
Generation is not automated via GH action on purpose as helpers should be fully stateless and intentionally marked by developer.
Command:
Before:
After: