refactor(fuzz): use mapsutil.Map type
#5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Closed
Closed
Mzack9999
requested changes
Aug 26, 2024
pkg/fuzz/component/path.go
Outdated
| original := originalValues[key].(string) | ||
| new := q.value.parsed.Map[key].(string) | ||
|
|
||
| original := originalValues.GetOrDefault(key, "").(string) |
There was a problem hiding this comment.
Shall we guard here using fmt.Sprint(..), anyway if it's a string we will get the same value of .(string)?
There was a problem hiding this comment.
Shall we guard here using
fmt.Sprint(..)[...]
If the values are always strings (or not?), sticking with the type assertion might be preferable for performance & type safety reasons.
[...] anyway if it's a string we will get the same value of
.(string)?
Since the type of map is any, we still need to do a type assertion.
There was a problem hiding this comment.
But we should ensure that the assertion went correctly with:
a, ok := c.(string)
if !ok {
continue
}
what do you think?
Signed-off-by: Dwi Siswanto <git@dw1.io>
dogancanbakir
approved these changes
Aug 26, 2024
Mzack9999
approved these changes
Aug 26, 2024
ehsandeep
approved these changes
Aug 28, 2024
ehsandeep
deleted the
dwisiswant0/refactor/fuzz/dataformat-use-mapsutil-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #5557
Checklist