Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflicting -U option for apk in Dockerfile #5578

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

PeterDaveHello
Copy link
Contributor

Proposed changes

The --no-cache option updates the index and avoids temporary files, making -U unnecessary, consistent with the subsequent apk add.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

The `--no-cache` option updates the index and avoids temporary files, making `-U` unnecessary, consistent with the subsequent `apk add`.
@auto-assign auto-assign bot requested a review from dogancanbakir August 26, 2024 18:51
@GeorginaReeder
Copy link

Thanks for your contribution @PeterDaveHello !

@ehsandeep ehsandeep merged commit bf58b4d into projectdiscovery:dev Aug 28, 2024
1 check passed
@PeterDaveHello PeterDaveHello deleted the ImproveDockerfile branch August 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants