feat(headless): supporting standard lifecycle events #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
…entNameLoad` also rename `Page.WaitLoad` to `Page.WaitStable` method. Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
call `ActionWaitFMP` instead of `WaitLoad` before take screenshot Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
dogancanbakir
approved these changes
Sep 19, 2024
| // NOTE(dwisiswant0): Mapping `ActionWaitLoad` to `Page.WaitStable`, | ||
| // just in case waiting for the `proto.PageLifecycleEventNameLoad` event | ||
| // doesn't meet expectations. | ||
| // case ActionWaitLoad, ActionWaitStable: |
There was a problem hiding this comment.
Dead code? We can remove it if it's redundant.
ehsandeep
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
@dwisiswant0 we can update the docs here - https://github.com/projectdiscovery/docs
ehsandeep
deleted the
dwisiswant0/feat/headless/std-lifecycle-events
branch
dwisiswant0
restored the
dwisiswant0/feat/headless/std-lifecycle-events
branch
dwisiswant0
deleted the
dwisiswant0/feat/headless/std-lifecycle-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updated headless actions:
waitloadNew headless actions:
waitdomwaitfcpwaitfmpwaitidlewaitstableClose #5631
Checklist