Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed trailing comma from the jsonl exporter #5861

Merged
merged 2 commits into from
Dec 1, 2024
Merged

removed trailing comma from the jsonl exporter #5861

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac0780
removed trailing comma from the jsonl exporter
bf-rbrown Nov 27, 2024
be1cb0f
adding the O_TRUNC flag when opening the file to explicitly indicate …
bf-rbrown Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/reporting/exporters/jsonl/jsonl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ func (exporter *Exporter) WriteRows() error {
return errors.Wrap(err, "failed to generate row for JSONL report")
}

// Add a trailing newline to the JSON byte array to confirm with the JSONL format
obj = append(obj, ',', '\n')
obj = append(obj, '\n')

// Attempt to append the JSON line to file specified in options.JSONLExport
if _, err = exporter.outputFile.Write(obj); err != nil {
Expand Down