Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic comparison helper function #91

Merged
merged 6 commits into from
Feb 26, 2023
Merged

Add generic comparison helper function #91

merged 6 commits into from
Feb 26, 2023

Conversation

xm1k3
Copy link
Contributor

@xm1k3 xm1k3 commented Feb 24, 2023 

func EqualsAll[T comparable](base T, all ...T) bool {}
func EqualsAny[T comparable](base T, all ...T) bool {}

@xm1k3 xm1k3 self-assigned this Feb 24, 2023
@xm1k3 xm1k3 added the Type: Enhancement Most issues will probably ask for additions or changes. label Feb 24, 2023
@xm1k3 xm1k3 linked an issue Feb 24, 2023 that may be closed by this pull request
Add generic comparison helper function #90
Closed
@xm1k3 xm1k3 marked this pull request as ready for review February 24, 2023 19:04
tarunKoyalwar
tarunKoyalwar requested changes Feb 26, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

func EqualsAll[T comparable](base T, all ...T) bool {}
func EqualsAny[T comparable](base T, all ...T) bool {}

both of the above functions should be in generic

tarunKoyalwar
tarunKoyalwar approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Mzack9999
Mzack9999 requested changes Feb 26, 2023
View reviewed changes
generic/generic.go Show resolved Hide resolved
@xm1k3 xm1k3 requested a review from Mzack9999 February 26, 2023 19:43
@Mzack9999 Mzack9999 merged commit b17bec2 into main Feb 26, 2023
@Mzack9999 Mzack9999 deleted the issue-90-equals-any-all branch February 26, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@xm1k3 xm1k3

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add generic comparison helper function
3 participants
@xm1k3 @Mzack9999 @tarunKoyalwar