Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Message): fix message with snapshot construction in known guild #188

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(Message): fix message with snapshot construction in known guild #188

merged 1 commit into from
Nov 25, 2024

Conversation

Snazzah
Copy link
Contributor

@Snazzah Snazzah commented Nov 25, 2024

Got this error a bunch during deployment... Seems to be because during the message.channel.guild check it doesn't account for null authors.

@TTtie TTtie added type: bug Something isn't working scope: structures Issues or pull requests affecting the structure definitions labels Nov 25, 2024
TTtie
TTtie approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@TTtie TTtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. After an additional look at the whole thing, message content transformations will have to be watched closely, but so far, I haven't seen a system message being forwarded, so it's probably OK.

@TTtie TTtie merged commit ac892d9 into projectdysnomia:dev Nov 25, 2024
1 check passed
@TTtie TTtie added this to the 0.2.2 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTtie TTtie TTtie approved these changes

Assignees
No one assigned
Labels
scope: structures Issues or pull requests affecting the structure definitions type: bug Something isn't working
Projects
To-do
Archived in project
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Snazzah @TTtie