add password option #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zheplusplus
reviewed
Oct 17, 2016
There was a problem hiding this comment.
Thanks for you patch.
I'm not sure if it's a good idea to configure the same password auth for each Redis in a cluster. There is some discussion that suggest usage of firewalls rather than a password.
| @@ -9,6 +9,7 @@ dump.rdb | |||
|
|
|||
| # Distribution / packaging | |||
| .Python | |||
| .idea/ | |||
There was a problem hiding this comment.
If you use an IDE that leaves something in the project directory, please add it to your gitignore_global.
| __version__ = '0.5.0' | ||
| REPO = 'https://github.com/HunanTV/redis-trib.py' | ||
| __version__ = '0.0.1' | ||
| REPO = 'https://github.com/Negashev/redis-trib.py' |
There was a problem hiding this comment.
I will appreciate if you could take care of this project but could you please use a higher version number?
| @@ -80,11 +80,11 @@ def addslots(t, begin, end): | |||
| addslots(t, begin, end) | |||
|
|
|||
|
|
|||
| def create(host_port_list, max_slots=1024): | |||
| def create(host_port_list, password=None, max_slots=1024): | |||
There was a problem hiding this comment.
The new optional parameter should be append after existing parameters for API compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will help some developers to make a secure cluster