Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fluent_args #130

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Refactor fluent_args #130

merged 1 commit into from
Jul 29, 2019

Conversation

zbraniecki
Copy link
Collaborator

Fixes #123

@zbraniecki zbraniecki requested a review from Manishearth July 27, 2019 08:18
@zbraniecki
Copy link
Collaborator Author

I went for a macro_rules. Would you suggest going for a proc macro instead?

Manishearth
Manishearth approved these changes Jul 29, 2019
View reviewed changes
Copy link
Collaborator

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can do it without a proc macro, that's good. This seems fine, I don't think a proc macro would help at all.

@zbraniecki zbraniecki merged commit 3e36b0d into projectfluent:master Jul 29, 2019
@zbraniecki zbraniecki deleted the bundle-args branch July 29, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor FluentArgs for better ergonomics
2 participants
@zbraniecki @Manishearth