Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use -C rather than -Z for instrument-coverage. #332

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

Using -C was stabilized in Rust 1.60.

Using `-C` was stabilized in Rust 1.60.
@getong
Copy link

getong commented Jan 26, 2024

This pr test well, would it be mered now?

@flodolo
Copy link
Contributor

flodolo commented Feb 3, 2024

@eemeli or @zbraniecki

Any chance one of you could take a look? This feels safe to merge (reference to the 1.60 release notes).

There are a couple of pending fixes to the workflows, and I would feel a lot more comfortable in reviewing them if the CI actually passes.

flodolo added a commit that referenced this pull request Feb 4, 2024
This PR includes changes from:
- #332: Use -C rathen than -Z for instrument-coverage
- #320: Replace unmaintained actions-rs/toolchain with dtolnay/rust-toolchain@master

It also updates actions/cache to v4.
@flodolo flodolo mentioned this pull request Feb 4, 2024
@flodolo flodolo merged commit b4e27fa into projectfluent:main Feb 5, 2024
4 checks passed
flodolo added a commit that referenced this pull request Feb 5, 2024
This PR includes changes from:
- #332: Use -C rathen than -Z for instrument-coverage
- #320: Replace unmaintained actions-rs/toolchain with dtolnay/rust-toolchain@master

It also updates actions/cache to v4.
@waywardmonkeys waywardmonkeys deleted the maybe-fix-ci-coverage branch February 5, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants