Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document current MSRV, note thoolchain, normalize metadata across workspace #348

Merged
merged 4 commits into from
May 6, 2024

Conversation

alerque
Copy link
Collaborator

@alerque alerque commented Mar 9, 2024

The MSRV information is the status quo not a change, only documented for tooling that recognizes this field.

Likewise the toolchain file is just for the aid of CI and developer tooling that happens to support it.

Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, but also, I think this would be better as a single PR that starts to use the workspace info, and then something setting up rust-version. It isn’t clear to me why set edition via the workspace, but not license or other info that is the same.

Cargo.toml Show resolved Hide resolved
fluent-cli/rust-toolchain Outdated Show resolved Hide resolved
fluent-pseudo/Cargo.toml Show resolved Hide resolved
@alerque
Copy link
Collaborator Author

alerque commented Mar 9, 2024

Yes I'd be find with splitting this up ... or appending a few more things that can be normalized via workspace meta data. I was just feeling my way around what is currently here so I have a better understanding of what will/won't break when other adjustments are made (e.g. will bumping dependencies as in other PR's change the MSRV).

But since I suggest not landing anything at all until we figure out a safe harbor release (which means access to crates.io etc.) I'll leave it together for now for discussion and if we want to refactor it later when we're ready to move on we can of course. I'm comfortable with Git rebase/revise/absorb etc.

@alerque alerque changed the title Document current MSRV and toolchain in relevant meta data files Document current MSRV, note thoolchain, normalize metadata across workspace Mar 15, 2024
@alerque alerque enabled auto-merge May 5, 2024 22:15
Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine to me for the workspace meta data, but I don't think we need the rust-toolchain

We'll need to fix up CI separately to do something more similar to what the Linebender repos do in that regard.

This is the status quo not a change, only documented for tooling that
recognizes this field.

Also sets the edition in the workspace and inherits both edition and
the MSRV (rust-version) field into all crates.
@alerque alerque merged commit 5d4338e into projectfluent:main May 6, 2024
5 checks passed
@alerque alerque deleted the msrv branch May 6, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants