Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete color in entry field unreadable #103

Closed
joede opened this issue Oct 23, 2015 · 9 comments
Closed

autocomplete color in entry field unreadable #103

joede opened this issue Oct 23, 2015 · 9 comments
Labels
bug Code working other than specified.
Milestone

Comments

@joede
Copy link

joede commented Oct 23, 2015

With the last update of the extension, the entry field for new tasks has no longer a bright background. If I start entering a new tast, the autocomplete mechanism shows me a suggestion with a unreadable color. It is a bright green text on a white background. As soon a I move the cursor to the end of the text, it is readable again.
This makes the autocomplete useless, since I have to choose between several more or less unique task names.
I have a sceenshot, but I can't attach it to this issue ("Something went really wrong, and we can’t process that file.").

@toupeira
Copy link
Contributor

Well we removed our custom styling exactly to avoid issues like these :) With Adwaita it looks fine:

workspace 1_001

Can you post a screenshot and share what theme you're using? Use imgur.com if you can't get it to work on GitHub.

@tstriker
Copy link
Contributor

@toupeira i guess joede is on an earlier version of gnome.

the fix would be to repush the version prior to style change, then apply the style change and mark that extension is now gnome 3.18.1+ (the style change was introduced in .1) and then push that :)

@joede
Copy link
Author

joede commented Oct 23, 2015

Oh sorry, I forgot to mention my environment. I'm using GNOME 1.14 from Debian 8. The theme is the original Adwaita. The entry field has the same background color and no border. Since I've forgotten the screenshot in my office, I've installed the extension on my privat notebook (Debian 8) with the same fault.

Here is the screenshot. Sorry, I don't know how to make inline images. Markdown doesn't show it.
http://up.picr.de/23483819oc.jpg

@tbaugis Does that mean there will be no fix? Which commit do you mean? My installation isn't that old, so I think it must be sometimes in summer that I've installed the extension

I've found the commit "Remove broken style from entry box". Is this the reason for my problems?

@toupeira
Copy link
Contributor

@tbaugis you mean using "shell-version": [ "3.18" ]? Not sure if it also supports point releases, and as usual the official docs on this stuff are very incomplete :( Or do you just mean mentioning the 3.18.1 requirement in the description/README?

@joede yep b8a966a removed the custom styling of the entry box. As a quick workaround you could also add those lines back to ~/.local/share/gnome-shell/extensions/hamster@projecthamster.wordpress.com/stylesheet.css, but I'll definitely try for a proper fix since lots of users are still on older Gnome versions.

@joede
Copy link
Author

joede commented Oct 23, 2015

@toupeira thanks for the fast answer. I'll try this at monday. And I agree to fix this for older version of GNOME too. Since I am a fan of Debian, I will always be "years" behind the bleeding edge. ;-)

@abhijit86k
Copy link

@toupeira and @joede I saw this issue on Debian 8 / Gnome Shell 3.14.1 too. Can confirm that reverting commit b8a966 works me.

@elbenfreund elbenfreund added the bug Code working other than specified. label Aug 18, 2016
@elbenfreund elbenfreund added this to the Backlog milestone Aug 18, 2016
@joede
Copy link
Author

joede commented Aug 18, 2016

@abhijit86k I haven't looked at this problem for a while now. Browsing at extensions.gnome.org doesn't show me an update! I'm currently running build 18 of the hamster extension with version 26 in the metadata.json. This version works here with the ARC shell theme, but I can't say if this is still the commit b8a966.

@abhijit86k
Copy link

@joede I am not using the version from extensions.gnome.org. (I'm unable to install any extensions from the browser, but thats a separate problem.) I cloned this repo on my machine and followed the instructions (made a softlink in ~/.local/...). I then created a separate branch where I reverted b8a966. You can see my branch and compare.

@joede
Copy link
Author

joede commented Aug 18, 2016

@abhijit86k I've compared my release with your branch and all JavaScript files match. Only the metadata.json differ. So we use the same revision. Now we have to wait for a fix. ;-)

@ghost ghost closed this as completed in #111 Aug 24, 2016
ghost pushed a commit that referenced this issue Aug 24, 2016
[#103] Provide a generic class on search input
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code working other than specified.
Projects
None yet
Development

No branches or pull requests

5 participants