-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hours sum and percentage of viewed time period in Totals view #348
base: master
Are you sure you want to change the base?
Conversation
for i, (label, value) in enumerate(self.values): | ||
percent = 100.0 * hours[i] / total |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No error checking if self._total
is not set (i.e. zero); in that case there will be a division by zero error here!
+1 Works fine for me. Thanks. |
Thank you for your feedback, it is much appreciated. Project hamster and its various sub-components is currently undergoing some major changes. We prepare the introduction of a rewritten codebase for most of the underlying functionality. A direct consequence of this is that it is unlikely that any open/new bugs within the current/old codebase will be fixed (unless someone steps up and offers to do so) as most resources currently available will be invested in making the rewrite prime time ready. If you are still interested in working on the new codebase (repositories: hamster-lib/cli/gtk/dbus) we would be most thrilled. Please feel free to either open a new issue with the relevant repository and/or join the discussion on the mailinglist. Thanks for your interest and support! Eric. |
Thanks for your contribution. The totals are displayed in the current master To be investigated again after the branch described in PR #302 is merged, |
That would be a good time to add the percentages, |
There is a pending check for CLA that is not actually valid. Seems we can't remove it, so just ignore it (see also #589). |
I needed to see the overall hours and the percentage of activities, categories and tags in the Totals view as hard numbers. I've added the values to the label of the corresponding bar graph in the Totals view. This might be of interest for others as well, so feel free to merge this contribution if you like.
Thanks!