Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entity serialization #51

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Refactor entity serialization #51

merged 5 commits into from
Sep 22, 2023

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Sep 22, 2023

Serializes entities in optimal way by writing
its index and generation as separate u32 varints.

Also update related docs. Looks like in Rust documentation they don't link types that are already in signature and refer to variable names which is make sense.

@Shatur Shatur requested a review from UkoeHB September 22, 2023 14:50
Serializes entities in optimal way by writing
its index and generation as separate u32 varints.

Also update related docs. Looks like in Rust documentation they don't
link types that are already in signature and refer to variable names
which is make sense.
@UkoeHB
Copy link
Collaborator

UkoeHB commented Sep 22, 2023

We need to keep track of this PR: bevyengine/bevy#3029 since it impacts entity serialization.

@Shatur Shatur enabled auto-merge (squash) September 22, 2023 18:34
@Shatur Shatur merged commit 54c4185 into master Sep 22, 2023
3 checks passed
@Shatur Shatur deleted the split-entity-serialzation branch September 22, 2023 18:43
@notverymoe
Copy link

notverymoe commented Sep 23, 2023

We need to keep track of this PR: bevyengine/bevy#3029 since it impacts entity serialization.

That PR has just been superseded, for more information track: bevyengine/bevy#9907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants