Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible w/ Lualine tabline #133

Closed
ghost opened this issue Nov 11, 2021 · 1 comment
Closed

Incompatible w/ Lualine tabline #133

ghost opened this issue Nov 11, 2021 · 1 comment
Assignees
Labels
assigned Under progress. bug Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 11, 2021

You are only able to see the the open tab when using this colorscheme with lualine's tabline. I believe that this happens when you put buffers in the tabline too.
Imgur link of bug

Lualine config

   require'lualine'.setup {
   options = {
        icons_enabled = true,
        theme = 'auto',
        component_separators = { left = '|', right = '|'},
        section_separators = { left = '', right = ''},
        disabled_filetypes = {},
        always_divide_middle = true,
    },
    sections = {
        lualine_a = {'mode'},
        lualine_b = {'branch', 'diff',
            {'diagnostics', sources={'nvim_lsp'}
            }},
        lualine_c = {'filename'},
        lualine_x = {'encoding', 'fileformat', 'filetype'},
        lualine_y = {'progress'},
        lualine_z = {'location'}
    },
    inactive_sections = {
        lualine_a = {},
        lualine_b = {},
        lualine_c = {'filename'},
        lualine_x = {'location'},
        lualine_y = {},
        lualine_z = {}
    },
    tabline = {
        lualine_a = {'tabs'},
        lualine_b = {},
        lualine_c = {},
        lualine_x = {},
        lualine_y = {},
        lualine_z = {}
    },
    extensions = {}
    },
@ful1e5 ful1e5 added bug Something isn't working help wanted Extra attention is needed labels Nov 18, 2021
@ful1e5
Copy link
Member

ful1e5 commented Nov 18, 2021

I like to receive PR for this bug.

@ful1e5 ful1e5 self-assigned this Dec 12, 2021
@ful1e5 ful1e5 added assigned Under progress. and removed help wanted Extra attention is needed labels Dec 12, 2021
@ful1e5 ful1e5 closed this as completed in c771411 Dec 12, 2021
ful1e5 added a commit to ful1e5/github-nvim-theme that referenced this issue Dec 13, 2021
Why?
----
Lualine now supports `tabline` and `buffers` as extension (projekt0n#97). Because
of this change lualine inherits highlights from `inactive` section of theme.
This inheritance makes some lualine highlights underlined (projekt0n#133) and
hard to see.

About Patch
-----------
This patch remove `underline` style from lualine plugin with new
background and foreground colors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant