Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error - "Invalid node type 'jsx_opening_element'" since last update #361

Closed
nilssonr opened this issue Aug 7, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@nilssonr
Copy link

nilssonr commented Aug 7, 2024

Hey, just updated to the latest version of this repository and immediately ran into an issue with my Angular project in Typescript. I have not tested if the theme breaks with any non-angular Typescript code.

Screenshot 2024-08-07 at 00 19 14

Please let me know what else I would need to provide in order to help troubleshoot this. And thanks for a great theme!

NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1720049189
Run "nvim -V1 -v" for more info

Reverting to the previous commit works great:

Screenshot 2024-08-07 at 00 26 17
@AzashiroMerume
Copy link

AzashiroMerume commented Aug 7, 2024

i was thinking it is typescript parser issue)). It breaks with my vue/nuxt project too, so it seems it is general typescript issue with this plugin & tree-sitter typescript parser

@tmillr
Copy link
Member

tmillr commented Aug 7, 2024

Thank you, I'll look into this. I think it might be an error that only occurs with typescript (while jsx, tsx, and js are ok). In 46c8c80, I overlooked the fact that even though this treesitter node is used for jsx, tsx, and js, it is not also used for ts for some reason lol. Unfortunately treesitter queries are one of the few things left that our CI tests don't cover yet (which hopefully we can change soon).

@tmillr tmillr added the bug Something isn't working label Aug 7, 2024
tmillr added a commit that referenced this issue Aug 7, 2024
Introduced in the previous commit, this query works with js, jsx, and
tsx, but not ts (i.e. a treesitter query error is thrown when opening a
regular `.ts` typescript file). We will have to figure out a workaround
to get it working with ts as well, but for now we will just disable it.

Issue: #361
@tmillr tmillr closed this as completed in e57805c Aug 7, 2024
@tmillr
Copy link
Member

tmillr commented Aug 7, 2024

Thank you for reporting this and bringing it to our attention! This should be fixed now. Please let us know if you experience any more problems (you may respond here with a comment, or open a new issue if it is unrelated to this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants